[PB-6385] Keep userID from joinCall in sessionStorage#236
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
meet-web | 9371902 | Commit Preview URL Branch Preview URL |
Jun 02 2026, 09:18 AM |
xabg2
approved these changes
May 20, 2026
7 tasks
[PB-6385] Change kickedout notification
7 tasks
7 tasks
CandelR
approved these changes
May 26, 2026
| payload = { userId: SessionStorageManager.instance.getAnonymousUUID() || '' }; | ||
| const userId = SessionStorageManager.instance.getUserID(); | ||
| if (userId) { | ||
| return await MeetingService.instance.leaveCall(roomId, { userId }); |
There was a problem hiding this comment.
If this causes an error, does the web crash?
Author
There was a problem hiding this comment.
No, but the server gets to do checks and log errors. If the user reloads before joining the call, leaveCall is dispatched, but it has no user ID, so technically no need for the call
[PB-6385] Fix reactDom is depricated error
[PB-6384] Don't use generic error for 403
|
Deploying meet-web with
|
| Latest commit: | 9371902 |
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ff90f975.meet-web.pages.dev |
| Updated (Europe/Madrid): | 2/6/2026, 11:17:56 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is the first half of the kick-out fix. It stores the ID returned by joinCall and uses it for leaving the call.
Also:
Related Pull Requests
Meet-server changes (second half)
Checklist
How Has This Been Tested?
QA in local
Additional Notes
Untill meet-server changes are merged, the kick out will only work every other time (1st, 3rd, 5th, etc). This is because each kick out cleans both users from the database (original and copy) - original because of the Jitsi Hook and copy because of leaveCall original user sent (with the same UserID that copy has)